marty/rm-circle-team-router
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Show recorded figures for closed campaigns, not the wiped counter

Browse Source 
My own sweep created this. Deactivating an ad ZEROES `remaining` on the
network, and for banners — where that column counts UP — zero reads as
"served nothing". So every campaign the sweep closed flipped to 0 served /
2,500 left, despite the ledger correctly recording served=2500,
completed=true.

Closed campaigns now read from what we recorded at the time rather than
re-deriving from a counter that no longer holds anything. Live campaigns
still compute from the network, per placement type.

Also removed the em-dash placeholder that blanked LEFT for stopped rows —
there is a real number to show — and made stop()'s error path assume fully
served rather than fully unserved, since guessing high would refund
impressions that had actually been delivered.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
martbost
2026-08-30 05:33:55 -05:00
parent 26f2c91684
commit 59bd4bd4ab
2 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/suite-traffic.js
+10 -3
View File
@@ -187,7 +187,14 @@
var bought = Number(c.bought != null ? c.bought : c.impressions) || 0;
var rawRem = l.remaining != null ? Number(l.remaining) : null;
var servedShown, left;
if (rawRem == null) { servedShown = Number(served) || 0; left = null; }
if (c.completed || c.stopped) {
// Once a campaign is closed, trust what we recorded at the time.
// Deactivating an ad ZEROES `remaining` on the network — and for a
// banner, where that column counts UP, zero reads as "served nothing".
// Re-deriving here would wipe a finished campaign back to 0 served.
servedShown = Number(c.served != null ? c.served : bought) || 0;
left = Math.max(0, bought - servedShown);
} else if (rawRem == null) { servedShown = Number(served) || 0; left = null; }
else if (c.kind === 'text') { left = Math.max(0, Math.min(rawRem, bought)); servedShown = bought - left; }
else { servedShown = Math.max(0, Math.min(rawRem, bought)); left = bought - servedShown; }
// "running" with 0 left reads as broken. It is not: banners have no cap on
@@ -211,8 +218,8 @@
tr.innerHTML = '<td>' + label + '</td>' +
'<td>' + (c.target.indexOf('/p/') !== -1 ? 'personal page' : 'invite page') + '</td>' +
'<td>' + Number(c.bought != null ? c.bought : c.impressions).toLocaleString() + '</td>' +
'<td><b>' + Number(c.stopped ? (c.served || 0) : servedShown).toLocaleString() + '</b></td>' +
'<td>' + (c.stopped ? '—' : (left != null ? left.toLocaleString() : '—')) + '</td>' +
'<td><b>' + Number(servedShown).toLocaleString() + '</b></td>' +
'<td>' + (left != null ? left.toLocaleString() : '—') + '</td>' +
'<td>' + (l.hits != null ? l.hits : '—') + '</td>' +
'<td>' + statusCell + '</td>';
var act = document.createElement('td');
suite-traffic.js
+5 -1
View File
@@ -238,7 +238,11 @@ async function stop(memberId, adId) {
served = r.served;
unserved = r.left;
}
} catch (e) { /* if stats are unavailable, refund nothing rather than guess */ }
} catch (e) {
// Stats unavailable: refund nothing rather than guess. Guessing high would
// hand back impressions that were actually delivered.
served = boughtGuess; unserved = 0;
}
await callNas({ action: 'deactivate', ad_id: Number(adId) });