Member profiles are optional: an invitation on the dashboard, never a gate
Manson's objection was that requiring a username and a verified email pulls the
build back toward a centralized database of members. He is right, and the
communication gap is real too, so the answer is to ask well rather than to force.
Nothing about holding a position, getting paid, reading the org, the training or
the tools depends on contact details any more. There is no onboarding gate: a
brand-new member registers, lands on their page and is never stopped by a modal.
The dashboard offers a dismissable card ("Not now" snoozes it for a week) that
leads with the thing members actually want, a note the moment a payout lands in
their wallet, and says outright that everything works the same without it. The
inbox is the one place that asks, because a message cannot be delivered to
someone who left no way to reach them, and even there it is an invitation.
The card sits above the tab strip rather than inside the dashboard pane: the page
opens on the pitch tab, so an invitation parked in the dashboard would never be
seen by the new members it is aimed at.
For leaders, /api/public/reach answers "how many of my org can I reach off the
site", scoped by chain.isInTeam so it leaks nothing upward or sideways. That
makes coverage a leader's own problem to solve by asking, not a rule imposed on
members.
Fixes a real bug found by the rewritten suite: the dismissable flag double-booked
as "single-field edit", so saving a username in the opt-in flow closed the dialog
instead of advancing to the email step. Split into oneShot; the suite now asserts
the advance as a regression.
QA, all green: profiles-unit 28, signin-fallback 7, gate-e2e 33 (rewritten to
assert the opposite of what it used to: no forced modal, dismissable everywhere,
visitors unaffected), join-flow 12 cold / 11 refuse / 12 warm.
qa/reseed.sh carries two hard-won guards: never name a shell variable TMP on
Windows (it inherits the system temp dir and rm -rf wipes it), and never pkill.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
martbost
+48
-18
@@ -1,25 +1,47 @@
|
||||
# RM Circle QA
|
||||
|
||||
## Member profile gate
|
||||
## Optional member profile
|
||||
|
||||
Since 2026-09-17 contact details are **optional** (Marty + Manson). Nothing about holding a
|
||||
position, getting paid, reading the org, the training or the tools may depend on a username or
|
||||
an email. There is no onboarding gate. The dashboard shows a dismissable invitation, and the
|
||||
inbox asks only because a message cannot be delivered to someone who left no way to reach them.
|
||||
|
||||
If a change to this area makes any of those suites fail on "NO modal is forced", stop. That
|
||||
assertion is the product decision, not a test detail.
|
||||
|
||||
```
|
||||
# unit: profiles.js in isolation (seeding, username rules, code flow, persistence)
|
||||
node qa/profiles-unit.mjs
|
||||
|
||||
# end to end: the real UI with real inbox sessions
|
||||
TMP=/d/tmp/rmc-e2e-data && rm -rf $TMP && mkdir -p $TMP
|
||||
ssh root@coolify.saasy.top "docker exec \$(docker ps -q --filter name=kr445fqc) cat /app/data/config.json" > $TMP/config.json
|
||||
echo '{}' > $TMP/sponsors.json
|
||||
echo '{"49":{"email":"seeded49@example.com","ts":"x"}}' > $TMP/member-alerts.json
|
||||
node -e "const m=require('./messages.js'); m.init({dataDir:process.argv[1],chain:require('./chain.js'),isProd:false}); require('fs').writeFileSync(process.argv[1]+'/tokens.txt', m.mintSession(21)+'\n'+m.mintSession(49));" $TMP
|
||||
PORT=3399 DATA_DIR=$TMP ADMIN_PASSWORD=localtest node server.js &
|
||||
LOCAL=http://127.0.0.1:3399 TOKEN=$(sed -n 1p $TMP/tokens.txt) TOKEN2=$(sed -n 2p $TMP/tokens.txt) node qa/gate-e2e.mjs
|
||||
# sign-in fallback: real secp256k1 signatures, including the abuse cases
|
||||
node qa/signin-fallback.mjs
|
||||
|
||||
# end to end: the real UI with real inbox sessions.
|
||||
# reseed.sh builds a throwaway data dir and starts the server on 3399.
|
||||
# NOT idempotent: the suite completes a profile for 21, so reseed before every run.
|
||||
bash qa/reseed.sh
|
||||
D=/d/tmp/rmc-e2e-data
|
||||
LOCAL=http://127.0.0.1:3399 TOKEN=$(sed -n 1p $D/tokens.txt) TOKEN2=$(sed -n 2p $D/tokens.txt) node qa/gate-e2e.mjs
|
||||
```
|
||||
|
||||
Covers: the gate fires on the owner's own page only, cannot be dismissed (Escape, backdrop, no close
|
||||
button), username and email validation, the code flow including a wrong code, completion landing on
|
||||
the dashboard tab, the profile card and in-place editing (dismissable), the seeded email pre-filling
|
||||
at step 2, visitors on every ID-keyed shared link seeing no gate and no 401, and phone-width layout.
|
||||
Covers: no automatic modal on the owner's own page or on a phone, the dismissable invitation and
|
||||
its 7-day snooze, opting in end to end (including the regression that saving a username must
|
||||
ADVANCE to the email step rather than close), abandoning the dialog at any point, the profile card
|
||||
and in-place editing, the seeded email pre-filling at step 2, the inbox's reason-led ask, visitors
|
||||
on every ID-keyed shared link seeing no prompt and no 401, and phone-width layout.
|
||||
|
||||
Two traps that cost real time, both now guarded in `reseed.sh`:
|
||||
|
||||
* **Never call a shell variable `TMP`, `TEMP` or `TMPDIR`.** Windows already sets them to the
|
||||
system temp directory, so `${TMP:-default}` silently inherits it and a following `rm -rf "$TMP"`
|
||||
wipes the machine's temp folder, including the tooling's own scratch files.
|
||||
* **Never add `pkill`/`taskkill`.** A broad pattern kills the tooling running the script. Stop the
|
||||
old server through the pid file.
|
||||
|
||||
The event flyer and the upgrade promo are full-screen overlays that legitimately cover `/my` once
|
||||
per browser/session and swallow clicks. Both E2E suites mark them already-seen via an init script
|
||||
rather than racing their fade-out.
|
||||
|
||||
`devCode` is returned by `/api/public/profile/email-start` only when `NODE_ENV !== 'production'`,
|
||||
which is what lets the test read the code. The live container runs with NODE_ENV=production.
|
||||
@@ -33,13 +55,21 @@ left #787 without a profile: the cached index does not yet know the brand-new po
|
||||
```
|
||||
node -e "const c=require('crypto'),s=require('./vendor/secp256k1.js'),{keccak256}=require('./vendor/sha3.js');s.utils.hmacSha256Sync=(k,...m)=>{const h=c.createHmac('sha256',Buffer.from(k));m.forEach(x=>h.update(Buffer.from(x)));return Uint8Array.from(h.digest())};const p=c.randomBytes(32),pub=s.getPublicKey(p,false);require('fs').writeFileSync('D:/tmp/rmc-qa-wallet.json',JSON.stringify({priv:p.toString('hex'),addr:'0x'+keccak256(Buffer.from(pub.slice(1))).slice(-40)}))"
|
||||
|
||||
TMP=/d/tmp/rmc-jd && rm -rf $TMP && mkdir -p $TMP && echo '[]' > $TMP/sponsors.json
|
||||
ssh root@coolify.saasy.top "docker exec \$(docker ps -q --filter name=kr445fqc) cat /app/data/config.json" > $TMP/config.json
|
||||
TEST_ADDR=<addr> TEST_ID=9001 COLD=1 PORT=3399 DATA_DIR=$TMP ADMIN_PASSWORD=localtest node qa/harness-server.js &
|
||||
LOCAL=http://127.0.0.1:3399 TEST_ADDR=<addr> TEST_PRIV=<priv> TEST_ID=9001 SCENARIO=sign node qa/join-flow-e2e.mjs
|
||||
LOCAL=http://127.0.0.1:3399 TEST_ADDR=<addr> TEST_PRIV=<priv> TEST_ID=9002 SCENARIO=refuse node qa/join-flow-e2e.mjs
|
||||
J=/d/tmp/rmc-jd && rm -rf $J && mkdir -p $J && echo '[]' > $J/sponsors.json # never name it TMP, see the trap above
|
||||
ssh root@coolify.saasy.top "docker exec \$(docker ps -q --filter name=kr445fqc) cat /app/data/config.json" > $J/config.json
|
||||
|
||||
# cold index (the state that broke #787) on 3400, warm index on 3402
|
||||
TEST_ADDR=<addr> TEST_ID=9001 COLD=1 PORT=3400 DATA_DIR=$J ADMIN_PASSWORD=localtest node qa/harness-server.js &
|
||||
TEST_ADDR=<addr> TEST_ID=9003 COLD=0 PORT=3402 DATA_DIR=$J-w ADMIN_PASSWORD=localtest node qa/harness-server.js &
|
||||
|
||||
LOCAL=http://127.0.0.1:3400 TEST_ADDR=<addr> TEST_PRIV=<priv> TEST_ID=9001 SCENARIO=sign node qa/join-flow-e2e.mjs
|
||||
LOCAL=http://127.0.0.1:3400 TEST_ADDR=<addr> TEST_PRIV=<priv> TEST_ID=9002 SCENARIO=refuse node qa/join-flow-e2e.mjs
|
||||
LOCAL=http://127.0.0.1:3402 TEST_ADDR=<addr> TEST_PRIV=<priv> TEST_ID=9003 SCENARIO=sign node qa/join-flow-e2e.mjs
|
||||
```
|
||||
|
||||
`COLD` defaults to ON: only `COLD=0` gives a warm index, so a missing `COLD` var does not silently
|
||||
run the cold case twice.
|
||||
|
||||
`SCENARIO=refuse` is the regression that matters most: a member who declines the signature must still
|
||||
complete the join and reach their dashboard. Never ship a join-flow change without it passing.
|
||||
|
||||
|
||||
+117
-128
@@ -1,128 +1,117 @@
|
||||
// End-to-end QA of the RM Circle required profile gate, driven through the real UI
|
||||
// with a real inbox session. Boot: LOCAL (default :3399), session cookie in COOKIE.
|
||||
import { pathToFileURL } from 'node:url';
|
||||
const PW = 'D:/Projects/MarketingAgent/qa-tester/node_modules/playwright';
|
||||
const { chromium } = (await import(pathToFileURL(PW + '/index.js').href)).default;
|
||||
const B = process.env.LOCAL || 'http://127.0.0.1:3399';
|
||||
const TOKEN = process.env.TOKEN; // ctb.msid for position 21
|
||||
const TOKEN2 = process.env.TOKEN2; // ctb.msid for position 49 (already complete)
|
||||
const ok = [], bad = [];
|
||||
const t = (n, c, extra) => { (c ? ok : bad).push(n + (c || !extra ? '' : ' -> ' + extra)); };
|
||||
const browser = await chromium.launch();
|
||||
const ctxFor = async (tok, mobile) => {
|
||||
const c = await browser.newContext(mobile ? { viewport: { width: 390, height: 844 }, isMobile: true, hasTouch: true } : { viewport: { width: 1280, height: 950 } });
|
||||
if (tok) await c.addCookies([{ name: 'ctb.msid', value: tok, url: B }]);
|
||||
return c;
|
||||
};
|
||||
const gateOpen = p => p.evaluate(() => !!document.querySelector('#pgCard'));
|
||||
const cardText = p => p.evaluate(() => { const c = document.querySelector('#pgCard'); return c ? c.innerText.replace(/\s+/g, ' ') : ''; });
|
||||
|
||||
// ---------- 1. the gate on the member's OWN page ----------
|
||||
const ctx = await ctxFor(TOKEN);
|
||||
const p = await ctx.newPage();
|
||||
await p.goto(B + '/my/21', { waitUntil: 'networkidle' }); await p.waitForTimeout(2500);
|
||||
t('gate appears on the owner\'s own page', await gateOpen(p));
|
||||
t('gate names the position and step', /position #21 . step 1 of 2/i.test(await cardText(p)), await cardText(p));
|
||||
|
||||
// cannot be dismissed
|
||||
await p.keyboard.press('Escape'); await p.waitForTimeout(400);
|
||||
t('Escape does not dismiss the required gate', await gateOpen(p));
|
||||
await p.mouse.click(8, 8); await p.waitForTimeout(400);
|
||||
t('backdrop click does not dismiss the required gate', await gateOpen(p));
|
||||
t('no close button on the required gate', !(await p.evaluate(() => !!document.querySelector('#pgClose'))));
|
||||
|
||||
// username validation
|
||||
const typeUser = async v => { await p.fill('#pgUser', v); await p.click('#pgUserSave'); await p.waitForTimeout(600); };
|
||||
await typeUser('ab');
|
||||
t('rejects a short username', /3 to 20/.test(await cardText(p)), await cardText(p));
|
||||
await typeUser('12345');
|
||||
t('rejects digits only', /at least one letter/.test(await cardText(p)));
|
||||
await typeUser('admin');
|
||||
t('rejects a reserved name', /reserved/.test(await cardText(p)));
|
||||
await typeUser('takenname');
|
||||
t('accepts a good username and moves to step 2', /step 2 of 2/i.test(await cardText(p)), await cardText(p));
|
||||
|
||||
// email step
|
||||
t('step 2 explains why and promises privacy', /never shown to other members/i.test(await cardText(p)));
|
||||
await p.fill('#pgEmail', 'not-an-email'); await p.click('#pgMailSend'); await p.waitForTimeout(700);
|
||||
t('rejects a malformed email', /does not look right/.test(await cardText(p)), await cardText(p));
|
||||
// grab the dev code straight off the API response
|
||||
let devCode = null;
|
||||
p.on('response', async r => { if (r.url().includes('/profile/email-start')) { try { const j = await r.json(); if (j.devCode) devCode = j.devCode; } catch (e) {} } });
|
||||
await p.fill('#pgEmail', 'qa-member@example.com'); await p.click('#pgMailSend'); await p.waitForTimeout(1400);
|
||||
t('code is sent and the code box appears', /Code sent to qa\*\*\*@example\.com/.test(await cardText(p)), await cardText(p));
|
||||
t('the reply masks the address', /qa\*\*\*@example\.com/.test(await cardText(p)));
|
||||
await p.fill('#pgCode', '000000'); await p.click('#pgCodeConfirm'); await p.waitForTimeout(800);
|
||||
t('wrong code refused', /does not match/.test(await cardText(p)), await cardText(p));
|
||||
t('dev code exposed locally for the test', !!devCode, String(devCode));
|
||||
await p.fill('#pgCode', devCode || '000000'); await p.click('#pgCodeConfirm'); await p.waitForTimeout(1200);
|
||||
t('right code completes the profile', /all set, @takenname/i.test(await cardText(p)), await cardText(p));
|
||||
await p.waitForTimeout(3200);
|
||||
t('gate closes itself after completion', !(await gateOpen(p)));
|
||||
|
||||
// ---------- 2. the profile card, and editing ----------
|
||||
t('completion lands on the dashboard tab', await p.evaluate(() => { const d = document.getElementById('tabDash'); return !!d && getComputedStyle(d).display !== 'none'; }));
|
||||
await p.reload({ waitUntil: 'networkidle' }); await p.waitForTimeout(2000);
|
||||
await p.evaluate(() => { const b = document.querySelector('.mp-tab[data-tab="dash"]'); if (b) b.click(); }); await p.waitForTimeout(1800);
|
||||
t('no gate on a completed profile', !(await gateOpen(p)));
|
||||
const body = await p.evaluate(() => document.body.innerText.replace(/\s+/g, ' '));
|
||||
t('dashboard shows the profile card', /Your member profile/.test(body), body.slice(0, 120));
|
||||
t('card shows the username', /@takenname/.test(body));
|
||||
t('card shows the confirmed email', /qa-member@example\.com/.test(body) && /confirmed/i.test(body));
|
||||
t('Change username button present', await p.evaluate(() => !!document.querySelector('#pgEditUser')));
|
||||
t('Change email button present', await p.evaluate(() => !!document.querySelector('#pgEditMail')));
|
||||
await p.click('#pgEditUser'); await p.waitForTimeout(900);
|
||||
t('edit modal opens', await gateOpen(p));
|
||||
t('edit modal HAS a close button', await p.evaluate(() => !!document.querySelector('#pgClose')));
|
||||
await p.click('#pgClose'); await p.waitForTimeout(600);
|
||||
t('edit modal can be dismissed', !(await gateOpen(p)));
|
||||
await p.click('#pgEditUser'); await p.waitForTimeout(800);
|
||||
await p.fill('#pgUser', 'renamedqa');
|
||||
await p.click('#pgUserSave'); await p.waitForTimeout(1400);
|
||||
t('rename saves and closes', !(await gateOpen(p)));
|
||||
await p.waitForTimeout(1200);
|
||||
t('card shows the new username', /@renamedqa/.test(await p.evaluate(() => document.body.innerText)));
|
||||
|
||||
// ---------- 3. scoping: never on someone else's page ----------
|
||||
const p2 = await ctx.newPage();
|
||||
await p2.goto(B + '/my/49', { waitUntil: 'networkidle' }); await p2.waitForTimeout(2000);
|
||||
await p2.evaluate(() => { const b = document.querySelector('.mp-tab[data-tab="dash"]'); if (b) b.click(); }); await p2.waitForTimeout(1600);
|
||||
t('no gate while browsing another position', !(await gateOpen(p2)));
|
||||
t('no profile card on another position\'s page', !/Your member profile/.test(await p2.evaluate(() => document.body.innerText)));
|
||||
t('the other page still renders', (await p2.evaluate(() => document.body.innerText)).length > 400);
|
||||
|
||||
// an INCOMPLETE member browsing someone else's page must also not be gated
|
||||
const ctx2 = await ctxFor(TOKEN2); const p3 = await ctx2.newPage();
|
||||
await p3.goto(B + '/my/21', { waitUntil: 'networkidle' }); await p3.waitForTimeout(2600);
|
||||
t('incomplete member is not gated on a teammate page', !(await gateOpen(p3)));
|
||||
await p3.goto(B + '/my/49', { waitUntil: 'networkidle' }); await p3.waitForTimeout(2600);
|
||||
t('incomplete member IS gated on their own page', await gateOpen(p3));
|
||||
t('their gate starts at the username step', /step 1 of 2/i.test(await cardText(p3)), await cardText(p3));
|
||||
await p3.fill('#pgUser', 'seeded49'); await p3.click('#pgUserSave'); await p3.waitForTimeout(900);
|
||||
t('seeded email is pre-filled at step 2', await p3.evaluate(() => { const i = document.querySelector('#pgEmail'); return i ? i.value : ''; }) === 'seeded49@example.com', await p3.evaluate(() => { const i = document.querySelector('#pgEmail'); return i ? i.value : 'no input'; }));
|
||||
t('copy tells them it is already on file', /already have this one on file/i.test(await cardText(p3)), await cardText(p3));
|
||||
|
||||
// ---------- 4. visitors ----------
|
||||
const ctxAnon = await ctxFor(null); const p4 = await ctxAnon.newPage();
|
||||
const anon401 = [];
|
||||
p4.on('response', r => { if (r.status() === 401 && r.url().includes('/profile')) anon401.push(r.url()); });
|
||||
for (const u of ['/my/21', '/my/49', '/join/21', '/fast-start?id=21', '/generation-pay?id=21', '/flyers?id=21']) {
|
||||
await p4.goto(B + u, { waitUntil: 'domcontentloaded' }); await p4.waitForTimeout(1600);
|
||||
const txt = await p4.evaluate(() => document.body.innerText);
|
||||
t('visitor: ' + u + ' renders with no gate', !(await gateOpen(p4)) && txt.length > 300, 'len ' + txt.length);
|
||||
}
|
||||
t('visitor sees no 401 from the profile endpoint', anon401.length === 0, anon401.join(','));
|
||||
|
||||
// ---------- 5. phone width ----------
|
||||
const ctxM = await ctxFor(TOKEN2, true); const p5 = await ctxM.newPage();
|
||||
await p5.goto(B + '/my/49', { waitUntil: 'networkidle' }); await p5.waitForTimeout(2600);
|
||||
t('gate renders on a phone', await gateOpen(p5));
|
||||
const fits = await p5.evaluate(() => { const c = document.querySelector('#pgCard'); if (!c) return false; const r = c.getBoundingClientRect(); return r.width <= window.innerWidth && r.left >= 0; });
|
||||
t('gate fits the phone viewport', fits);
|
||||
const noHScroll = await p5.evaluate(() => document.documentElement.scrollWidth <= window.innerWidth + 2);
|
||||
t('no horizontal scroll on a phone', noHScroll);
|
||||
|
||||
console.log('\nPASS ' + ok.length);
|
||||
for (const b of bad) console.log('FAIL ' + b);
|
||||
await browser.close();
|
||||
process.exit(bad.length ? 1 : 0);
|
||||
// End-to-end QA of the RM Circle OPTIONAL member profile (Marty + Manson, 2026-09-17).
|
||||
//
|
||||
// The rule this suite defends: contact details are NEVER required. Nothing about
|
||||
// holding a position, getting paid, reading the org, the training or the tools may
|
||||
// depend on them. The only place they are asked for is the inbox, where a message
|
||||
// cannot be delivered without them, and even there it is an invitation.
|
||||
//
|
||||
// Run: LOCAL=... TOKEN=<msid for 21> TOKEN2=<msid for 49> node qa/gate-e2e.mjs
|
||||
import { pathToFileURL } from 'node:url';
|
||||
const PW = 'D:/Projects/MarketingAgent/qa-tester/node_modules/playwright';
|
||||
const { chromium } = (await import(pathToFileURL(PW + '/index.js').href)).default;
|
||||
const B = process.env.LOCAL || 'http://127.0.0.1:3399';
|
||||
const TOKEN = process.env.TOKEN; // position 21, no profile yet
|
||||
const TOKEN2 = process.env.TOKEN2; // position 49, seeded email, no username
|
||||
const ok = [], bad = [];
|
||||
const t = (n, c, extra) => { (c ? ok : bad).push(n + (c || !extra ? '' : ' -> ' + extra)); };
|
||||
const browser = await chromium.launch();
|
||||
const ctxFor = async (tok, mobile) => {
|
||||
const c = await browser.newContext(mobile ? { viewport: { width: 390, height: 844 }, isMobile: true, hasTouch: true } : { viewport: { width: 1280, height: 950 } });
|
||||
// The event flyer and the upgrade promo are full-screen overlays that legitimately
|
||||
// cover /my once per browser/session. They are not what this suite tests, and they
|
||||
// swallow clicks, so mark them already-seen instead of racing their fade-out.
|
||||
await c.addInitScript(() => {
|
||||
const g = Storage.prototype.getItem;
|
||||
Storage.prototype.getItem = function (k) {
|
||||
if (/^rmc-promo-/.test(k)) return 'seen';
|
||||
if (/^rmc-announce-/.test(k)) return 'done';
|
||||
return g.call(this, k);
|
||||
};
|
||||
});
|
||||
if (tok) await c.addCookies([{ name: 'ctb.msid', value: tok, url: B }]);
|
||||
return c;
|
||||
};
|
||||
const modalOpen = p => p.evaluate(() => !!document.querySelector('#pgCard'));
|
||||
const cardText = p => p.evaluate(() => { const c = document.querySelector('#pgCard'); return c ? c.innerText.replace(/\s+/g, ' ') : ''; });
|
||||
const openDash = async p => { await p.evaluate(() => { const b = document.querySelector('.mp-tab[data-tab="dash"]'); if (b) b.click(); }); await p.waitForTimeout(1800); };
|
||||
|
||||
// ---------- 1. nothing is forced ----------
|
||||
const ctx = await ctxFor(TOKEN);
|
||||
const p = await ctx.newPage();
|
||||
await p.goto(B + '/my/21', { waitUntil: 'networkidle' }); await p.waitForTimeout(2600);
|
||||
t('NO automatic modal on the member\'s own page', !(await modalOpen(p)));
|
||||
await openDash(p);
|
||||
t('still no modal after opening the dashboard', !(await modalOpen(p)));
|
||||
const body1 = await p.evaluate(() => document.body.innerText.replace(/\s+/g, ' '));
|
||||
t('a dismissable invitation card is shown instead', /Get a note when you get paid/i.test(body1), body1.slice(0, 120));
|
||||
t('the card says it is optional', /optional/i.test(body1));
|
||||
t('the card promises nothing else changes', /work exactly the same without it/i.test(body1));
|
||||
t('"Not now" is offered', await p.evaluate(() => !!document.getElementById('pcNo')));
|
||||
|
||||
// declining costs nothing and snoozes
|
||||
await p.click('#pcNo'); await p.waitForTimeout(600);
|
||||
t('declining removes the card', !(await p.evaluate(() => !!document.getElementById('pcNo'))));
|
||||
t('declining leaves the dashboard fully usable', (await p.evaluate(() => document.body.innerText)).length > 500);
|
||||
await p.reload({ waitUntil: 'networkidle' }); await p.waitForTimeout(2200); await openDash(p);
|
||||
t('the card stays away after declining (snoozed)', !(await p.evaluate(() => !!document.getElementById('pcNo'))));
|
||||
t('and still no modal', !(await modalOpen(p)));
|
||||
|
||||
// ---------- 2. opting in works, and the dialog can be abandoned ----------
|
||||
await p.evaluate(() => { try { localStorage.removeItem('rmc.profileSnooze'); } catch (e) {} });
|
||||
await p.reload({ waitUntil: 'networkidle' }); await p.waitForTimeout(2200); await openDash(p);
|
||||
t('the card returns once the snooze is cleared', await p.evaluate(() => !!document.getElementById('pcGo')));
|
||||
await p.click('#pcGo'); await p.waitForTimeout(1000);
|
||||
t('the dialog opens on request', await modalOpen(p));
|
||||
t('the dialog can always be closed', await p.evaluate(() => !!document.getElementById('pgClose')));
|
||||
t('it opens at the username step, worded as optional', /changeable any time/i.test(await cardText(p)), await cardText(p));
|
||||
await p.click('#pgClose'); await p.waitForTimeout(600);
|
||||
t('abandoning the dialog is allowed', !(await modalOpen(p)));
|
||||
|
||||
// complete it for real
|
||||
await p.click('#pcGo'); await p.waitForTimeout(900);
|
||||
let devCode = null;
|
||||
p.on('response', async r => { if (r.url().includes('/profile/email-start')) { try { const j = await r.json(); if (j.devCode) devCode = j.devCode; } catch (e) {} } });
|
||||
await p.fill('#pgUser', 'optin21'); await p.click('#pgUserSave'); await p.waitForTimeout(1100);
|
||||
// the regression that matters: saving a username must ADVANCE to the email step,
|
||||
// not close the dialog. The dismissable flag used to double as "single-field edit".
|
||||
t('saving the username advances to the email step', await p.evaluate(() => !!document.getElementById('pgEmail')), await cardText(p));
|
||||
t('the email step leads with payout alerts, not messaging', /payout lands in your wallet/i.test(await cardText(p)), await cardText(p));
|
||||
await p.fill('#pgEmail', 'optin@example.com'); await p.click('#pgMailSend'); await p.waitForTimeout(1400);
|
||||
await p.fill('#pgCode', devCode || '000000'); await p.click('#pgCodeConfirm'); await p.waitForTimeout(1500);
|
||||
t('opting in completes', /all set, @optin21/i.test(await cardText(p)) || !(await modalOpen(p)), await cardText(p));
|
||||
await p.waitForTimeout(3200);
|
||||
await p.reload({ waitUntil: 'networkidle' }); await p.waitForTimeout(2200); await openDash(p);
|
||||
const body2 = await p.evaluate(() => document.body.innerText.replace(/\s+/g, ' '));
|
||||
t('the invitation card is gone once done', !/Get a note when you get paid/i.test(body2));
|
||||
t('the profile card shows their details', /Your member profile/.test(body2) && /@optin21/.test(body2), body2.slice(0, 120));
|
||||
t('they can still change it later', await p.evaluate(() => !!document.getElementById('pgEditUser')));
|
||||
|
||||
// ---------- 3. the inbox asks only where it matters ----------
|
||||
const ctx2 = await ctxFor(TOKEN2); const p3 = await ctx2.newPage();
|
||||
await p3.goto(B + '/my/49', { waitUntil: 'networkidle' }); await p3.waitForTimeout(2400); await openDash(p3);
|
||||
t('no modal for the member without contact details', !(await modalOpen(p3)));
|
||||
const body3 = await p3.evaluate(() => document.body.innerText.replace(/\s+/g, ' '));
|
||||
t('the inbox explains why it needs an address', /Messages reach you here only/i.test(body3), body3.slice(0, 140));
|
||||
t('the inbox ask is phrased as optional', /Optional, private, removable/i.test(body3));
|
||||
|
||||
// ---------- 4. nothing changed for visitors or shared links ----------
|
||||
const anon = await ctxFor(null); const p4 = await anon.newPage();
|
||||
const anon401 = [];
|
||||
p4.on('response', r => { if (r.status() === 401 && /\/profile|\/reach/.test(r.url())) anon401.push(r.url()); });
|
||||
for (const u of ['/my/21', '/my/49', '/join/21', '/fast-start?id=21', '/generation-pay?id=21', '/flyers?id=21']) {
|
||||
await p4.goto(B + u, { waitUntil: 'domcontentloaded' }); await p4.waitForTimeout(1500);
|
||||
const txt = await p4.evaluate(() => document.body.innerText);
|
||||
t('visitor: ' + u + ' renders, no prompt of any kind', !(await modalOpen(p4)) && !/Get a note when you get paid/i.test(txt) && txt.length > 300, 'len ' + txt.length);
|
||||
}
|
||||
t('visitor triggers no 401s', anon401.length === 0, anon401.join(','));
|
||||
|
||||
// ---------- 5. phone ----------
|
||||
const ctxM = await ctxFor(TOKEN2, true); const p5 = await ctxM.newPage();
|
||||
await p5.goto(B + '/my/49', { waitUntil: 'networkidle' }); await p5.waitForTimeout(2400); await openDash(p5);
|
||||
t('no forced modal on a phone', !(await modalOpen(p5)));
|
||||
t('no horizontal scroll on a phone', await p5.evaluate(() => document.documentElement.scrollWidth <= window.innerWidth + 2));
|
||||
|
||||
console.log('PASS ' + ok.length);
|
||||
for (const b of bad) console.log('FAIL ' + b);
|
||||
await browser.close();
|
||||
process.exit(bad.length ? 1 : 0);
|
||||
|
||||
+25
-5
@@ -33,6 +33,16 @@ const t = (n, c, extra) => { (c ? ok : bad).push(n + (c || !extra ? '' : ' -> '
|
||||
|
||||
const browser = await chromium.launch();
|
||||
const ctx = await browser.newContext({ viewport: { width: 1280, height: 950 } });
|
||||
// The event flyer and upgrade promo are full-screen overlays that legitimately cover
|
||||
// /my once per browser/session. They are not under test here and they swallow clicks.
|
||||
await ctx.addInitScript(() => {
|
||||
const g = Storage.prototype.getItem;
|
||||
Storage.prototype.getItem = function (k) {
|
||||
if (/^rmc-promo-/.test(k)) return 'seen';
|
||||
if (/^rmc-announce-/.test(k)) return 'done';
|
||||
return g.call(this, k);
|
||||
};
|
||||
});
|
||||
const page = await ctx.newPage();
|
||||
|
||||
// real signing, called from the page (exposeFunction sidesteps the page's strict CSP)
|
||||
@@ -108,16 +118,26 @@ if (SCENARIO === 'sign') {
|
||||
t('a signature was requested right after the join', (qa.signAsked || 0) >= 1, JSON.stringify(qa));
|
||||
t('an inbox session was created', hasSession, cookies.map(c => c.name).join(','));
|
||||
await page.waitForTimeout(2500);
|
||||
const gate = await page.evaluate(() => !!document.querySelector('#pgCard'));
|
||||
t('the profile gate appears on their dashboard', gate);
|
||||
const card = await page.evaluate(() => { const c = document.querySelector('#pgCard'); return c ? c.innerText.replace(/\s+/g, ' ') : ''; });
|
||||
t('the gate is for THEIR position', new RegExp('position #' + NEW_ID, 'i').test(card), card.slice(0, 90));
|
||||
// Since 2026-09-17 contact details are optional, so a brand-new member must NOT be
|
||||
// met by a modal. They get a dismissable invitation on their own dashboard instead.
|
||||
t('NO modal is forced on a brand-new member', !(await page.evaluate(() => !!document.querySelector('#pgCard'))));
|
||||
const invite = await page.evaluate(() => !!document.getElementById('pcGo'));
|
||||
t('the optional invitation is offered instead', invite);
|
||||
t('and it can be declined', await page.evaluate(() => !!document.getElementById('pcNo')));
|
||||
if (invite) {
|
||||
await page.click('#pcGo'); await page.waitForTimeout(1400);
|
||||
const card = await page.evaluate(() => { const c = document.querySelector('#pgCard'); return c ? c.innerText.replace(/\s+/g, ' ') : ''; });
|
||||
t('opening it addresses THEIR position', new RegExp('position #' + NEW_ID, 'i').test(card), card.slice(0, 90));
|
||||
t('and they can close it again', await page.evaluate(() => !!document.getElementById('pgClose')));
|
||||
}
|
||||
} else {
|
||||
t('the signature was refused by the wallet', (qa.signRefused || 0) >= 1, JSON.stringify(qa));
|
||||
t('REGRESSION: the join still completed and redirected', /\/my\//.test(page.url()), page.url());
|
||||
t('no inbox session, as expected', !hasSession);
|
||||
const gate = await page.evaluate(() => !!document.querySelector('#pgCard'));
|
||||
t('no gate without a session, page still usable', !gate);
|
||||
t('no modal without a session, page still usable', !gate);
|
||||
t('and no invitation either, since we cannot know who they are',
|
||||
!(await page.evaluate(() => !!document.getElementById('pcGo'))));
|
||||
const txt = await page.evaluate(() => document.body.innerText);
|
||||
t('the dashboard still renders for them', txt.length > 300, 'len ' + txt.length);
|
||||
}
|
||||
|
||||
@@ -0,0 +1,35 @@
|
||||
#!/usr/bin/env bash
|
||||
# Rebuild a throwaway data dir + server for the profile E2E suite.
|
||||
# The suite completes a profile for 21, so it is NOT idempotent: reseed every run.
|
||||
#
|
||||
# Two rules learned the hard way, do not undo them:
|
||||
# * NEVER name the data-dir variable TMP/TEMP/TMPDIR. On Windows those are already
|
||||
# set to the system temp directory, so `${TMP:-default}` silently inherits it and
|
||||
# the rm -rf below wipes the machine's temp folder instead of the throwaway dir.
|
||||
# * NEVER add pkill/taskkill. A broad pattern kills the tooling running this script.
|
||||
# Stop the old server through the pid file instead.
|
||||
#
|
||||
# Usage: bash qa/reseed.sh (then read $RMCQA_DIR/tokens.txt)
|
||||
set -e
|
||||
RMCQA_DIR=${RMCQA_DIR:-/d/tmp/rmc-e2e-data}
|
||||
PORT=${PORT:-3399}
|
||||
case "$RMCQA_DIR" in
|
||||
/d/tmp/*|/D/tmp/*) ;;
|
||||
*) echo "refusing: RMCQA_DIR must live under /d/tmp (got '$RMCQA_DIR')"; exit 2 ;;
|
||||
esac
|
||||
if [ -f "$RMCQA_DIR/server.pid" ]; then kill "$(cat "$RMCQA_DIR/server.pid")" 2>/dev/null || true; sleep 2; fi
|
||||
rm -rf "$RMCQA_DIR"; mkdir -p "$RMCQA_DIR"
|
||||
if [ -f /d/tmp/rmc-config-cache.json ]; then cp /d/tmp/rmc-config-cache.json "$RMCQA_DIR/config.json";
|
||||
else ssh -o StrictHostKeyChecking=no root@coolify.saasy.top \
|
||||
"docker exec \$(docker ps -q --filter name=kr445fqc) cat /app/data/config.json" > "$RMCQA_DIR/config.json"
|
||||
cp "$RMCQA_DIR/config.json" /d/tmp/rmc-config-cache.json; fi
|
||||
echo '[]' > "$RMCQA_DIR/sponsors.json"
|
||||
echo '{"49":{"email":"seeded49@example.com","ts":"x"}}' > "$RMCQA_DIR/member-alerts.json"
|
||||
node -e "const m=require('./messages.js'); m.init({dataDir:process.argv[1],chain:require('./chain.js'),isProd:false}); require('fs').writeFileSync(process.argv[1]+'/tokens.txt', m.mintSession(21)+'\n'+m.mintSession(49));" "$RMCQA_DIR"
|
||||
PORT=$PORT DATA_DIR=$RMCQA_DIR ADMIN_PASSWORD=localtest node server.js > "$RMCQA_DIR/server.log" 2>&1 &
|
||||
echo $! > "$RMCQA_DIR/server.pid"
|
||||
for i in $(seq 1 40); do
|
||||
if [ "$(curl -s -o /dev/null -w %{http_code} "http://127.0.0.1:$PORT/my/21" 2>/dev/null)" = "200" ]; then echo "ready on $PORT"; exit 0; fi
|
||||
sleep 1
|
||||
done
|
||||
echo "server did not come up"; tail -20 "$RMCQA_DIR/server.log"; exit 1
|
||||
Reference in New Issue
Block a user